Bug 31406

Summary: [Qt] Fix typo ce_time.cpp -> ce_time.c
Product: WebKit Reporter: Ismail Donmez <ismail>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Fix typo
koivisto: review+, commit-queue: commit-queue-
Provide a changelog none

Description Ismail Donmez 2009-11-12 05:51:46 PST
There is no file named ce_time.cpp, it should be ce_time.c . Patch attached.
Comment 1 Ismail Donmez 2009-11-12 05:52:14 PST
Created attachment 43062 [details]
Fix typo
Comment 2 Antti Koivisto 2009-11-12 09:53:33 PST
rs=me
Comment 3 Ismail Donmez 2009-11-12 13:15:43 PST
How do I get this committed ;)
Comment 4 WebKit Commit Bot 2009-11-12 13:19:51 PST
Comment on attachment 43062 [details]
Fix typo

Rejecting patch 43062 from commit-queue.

ismail@namtrac.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Comment 5 WebKit Commit Bot 2009-11-12 18:28:17 PST
Comment on attachment 43062 [details]
Fix typo

Rejecting patch 43062 from commit-queue.

Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
http://webkit.org/coding/contributing.html
Comment 6 Ismail Donmez 2009-11-13 06:48:29 PST
Created attachment 43154 [details]
Provide a changelog
Comment 7 WebKit Commit Bot 2009-11-13 11:48:30 PST
Comment on attachment 43154 [details]
Provide a changelog

Rejecting patch 43154 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11621 test cases.
http/tests/xmlhttprequest/access-control-and-redirects.html -> crashed

Exiting early after 1 failures. 9148 tests run.
435.34s total testing time

9147 test cases (99%) succeeded
1 test case (<1%) crashed
5 test cases (<1%) had stderr output
Comment 8 Eric Seidel (no email) 2009-11-13 11:57:09 PST
Comment on attachment 43154 [details]
Provide a changelog

Filed bug 31461.  Not your fault. :(
Comment 9 WebKit Commit Bot 2009-11-13 12:11:27 PST
Comment on attachment 43154 [details]
Provide a changelog

Rejecting patch 43154 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11621 test cases.
inspector/console-dir.html -> crashed

Exiting early after 1 failures. 9312 tests run.
486.83s total testing time

9311 test cases (99%) succeeded
1 test case (<1%) crashed
5 test cases (<1%) had stderr output
Comment 10 Eric Seidel (no email) 2009-11-13 12:13:44 PST
Comment on attachment 43154 [details]
Provide a changelog

Sorry, the build is in very bad shape right now.  Added the crash report to bug 30835.  Let's try again.
Comment 11 WebKit Commit Bot 2009-11-13 12:30:03 PST
Comment on attachment 43154 [details]
Provide a changelog

Clearing flags on attachment: 43154

Committed r50962: <http://trac.webkit.org/changeset/50962>
Comment 12 WebKit Commit Bot 2009-11-13 12:30:08 PST
All reviewed patches have been landed.  Closing bug.