rewrite fast/dom/Window/window-screen-properties to be slightly more portable

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Dirk Pranke]

Right now this test will fail unless your screen is set to a single fixed colordepth (24 on the Mac). Even if we have platform-specific overrides, it means everyone on that platform has to have the same colordepth, which at least for Chromium's infrastructure isn't practical.

I'd like to rewrite this to accept either 16, 24, or 32 as values. That seems like it's enough to ensure the property isn't returning garbage, but is still pretty flexible.

[Dirk Pranke]

Created attachment 43000 [details]
proposed rewrite of patch

[Dmitry Titov]

Comment on attachment 43000 [details]
proposed rewrite of patch

The patch seems to contain unrelated png files.

Also, while you are at it, does it make sense to verify that pixelDepth==colorDepth or is it not actually always the case?

r- because of extra png files

[Dirk Pranke]

grr. Not only were there pngs that snuck in (I'm not sure how), there was a typo in the test file.

per http://www.quirksmode.org/dom/w3c_cssom.html , there may be differences between pixeldepth and colordepth on older unix machines (where bpp <= 8). I don't know if we even support bpp <= 8, so I could certainly add that check if we wanted.

[Dirk Pranke]

Created attachment 43013 [details]
revised patch - corrects typo in test case, drops mistakenly included pngs

[Dmitry Titov]

Comment on attachment 43013 [details]
revised patch - corrects typo in test case, drops mistakenly included pngs

Almost there. I think you also need to update platform/win/fast/dom/Window/window-screen-properties-expected.txt

[Dmitry Titov]

Err, not to update but rather delete since your updated test removes a need for a platform-specific snapshot.

[Dirk Pranke]

Created attachment 43021 [details]
drop unnecessary win expectation

Good catch, actually we should be able to delete it.

[WebKit Commit Bot]

Comment on attachment 43021 [details]
drop unnecessary win expectation

Clearing flags on attachment: 43021

Committed r50857: <http://trac.webkit.org/changeset/50857>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.