Bug 31360

Summary: [Chromium] Upstream fixes to SocketStreamHandles
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebKit Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: ukai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch dglazkov: review+, commit-queue: commit-queue-

Description Nate Chapin 2009-11-11 10:22:33 PST
http://trac.webkit.org/changeset/50811 removed some methods from SocketStreamHandleClient that we exposed in the Chromium API.  Remove them there too.
Comment 1 Nate Chapin 2009-11-11 10:26:29 PST
Created attachment 42975 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2009-11-11 10:32:40 PST
Comment on attachment 42975 [details]
patch

r=me.
Comment 3 WebKit Commit Bot 2009-11-12 19:06:32 PST
Comment on attachment 42975 [details]
patch

Rejecting patch 42975 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Dimitri Glazkov', '--force']" exit_code: 1
Last 500 characters of output:
ebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/chromium/src/SocketStreamHandle.cpp
Hunk #1 FAILED at 60.
Hunk #2 FAILED at 108.
Hunk #3 FAILED at 119.
Hunk #4 FAILED at 231.
4 out of 4 hunks FAILED -- saving rejects to file WebKit/chromium/src/SocketStreamHandle.cpp.rej
patching file WebKit/chromium/public/WebSocketStreamHandleClient.h
Hunk #1 FAILED at 43.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/public/WebSocketStreamHandleClient.h.rej
Comment 4 Fumitoshi Ukai 2009-11-12 21:05:45 PST
Landed at r50820