Bug 313534
| Summary: | Improve libatomic test in WebKitCompilerFlags.cmake | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alberto Garcia <berto> |
| Component: | CMake | Assignee: | Alberto Garcia <berto> |
| Status: | REOPENED | ||
| Severity: | Enhancement | CC: | mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 313565 | ||
| Bug Blocks: | |||
Alberto Garcia
The current test tries to build a test source that uses atomic variables. It is used to detect whether linking with libatomic is necessary.
However, the test assumes that using libatomic always succeeds. This should generally be the case, but if it doesn't we should stop immediately and show an error message.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alberto Garcia
Pull request: https://github.com/WebKit/WebKit/pull/63783
EWS
Committed 312202@main (36c3761def82): <https://commits.webkit.org/312202@main>
Reviewed commits have been landed. Closing PR #63783 and removing active labels.
Marta Darbinyan
Reopened Bugzilla.
REGRESSION(312202@main): Broken Win-Build-EWS, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=313565.