Bug 313509
| Summary: | [CMake][Mac] WebKitTestRunner/TestWebKitAPI/TestIPC fail to link: WTF OBJECT library brings in unresolved bmalloc | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Lewis <simon.lewis> |
| Component: | CMake | Assignee: | Simon Lewis <simon.lewis> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Lewis
Listing bare `WTF` (an OBJECT library on Mac) in these targets' _LIBRARIES pulls every WTF .o onto the link line, which references unlinked bmalloc symbols and duplicates WTF static state alongside JavaScriptCore's; drop it and let JSC's re-export supply WTF, adding JavaScriptCore/Security/ICU_INCLUDE_DIRS where they were riding in on WTF's INTERFACE.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 312165@main (dc829e1a2e28): <https://commits.webkit.org/312165@main>
Reviewed commits have been landed. Closing PR #63760 and removing active labels.