Bug 31347

Summary:

Need to also show/hide the inspector window to avoid having problems with code assuming it is realized

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

xan.lopez

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
show window for the inspector	jmalonzo: review+, gustavo: commit-queue-

Gustavo Noronha (kov)

Reported 2009-11-11 04:18:33 PST

Some inspector tests sometimes crash because of code assuming we displayed the window when we should. Discussing this with Xan, we decided to simply show the inspector window.

Attachments
show window for the inspector (3.33 KB, patch) 2009-11-11 08:58 PST, Gustavo Noronha (kov)	jmalonzo: review+ gustavo: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gustavo Noronha (kov)

Comment 1 2009-11-11 08:58:42 PST

Created attachment 42966 [details] show window for the inspector Here it goes.

Jan Alonzo

Comment 2 2009-11-11 11:08:34 PST

Comment on attachment 42966 [details] show window for the inspector r=me.

Gustavo Noronha (kov)

Comment 3 2009-11-11 13:12:21 PST

Landed as r50837, thanks!

Note You need to log in before you can comment on or make changes to this bug.