Bug 31346

Summary:

Should not print javascript console messages to stdout

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Gtk

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
print console messages with g_warning	gustavo: commit-queue-
print console messages to stderr	zecke: review+, gustavo: commit-queue-

Description Gustavo Noronha (kov) 2009-11-11 03:58:46 PST

Currently javascript console messages are printed to stdout using g_print. This is not a good idea. stderr should be used, at least.

Comment 1 Gustavo Noronha (kov) 2009-11-11 04:02:57 PST

Created attachment 42948 [details]
print console messages with g_warning

This helps some tests fail from time to time. Javascript console messages show up on the test results.

Comment 2 Gustavo Noronha (kov) 2009-11-11 04:03:29 PST

(In reply to comment #1)
> This helps some tests fail from time to time. Javascript console messages show
> up on the test results.

To be clear, 'This' here means the problem this patch fixes, not the fix =).

Comment 3 Gustavo Noronha (kov) 2009-11-11 04:12:06 PST

Created attachment 42949 [details]
print console messages to stderr

Use g_message instead of g_warning, following suggestion by Benjamin Otte.

Comment 4 Gustavo Noronha (kov) 2009-11-11 04:46:39 PST

Landed as r50799.