Bug 31344

Summary: [Qt] Fix a problem in the qmake project files that caused nmake to reparse idl files every time.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Qt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch hausmann: review-

Jocelyn Turcotte
Reported 2009-11-11 03:33:08 PST
The processing of an idl file could generate both a .cpp and a .h. The way it worked is that the .cpp would be dependent on the idl, but the .h was dependent on the .cpp using a rule that reparse all idl files of that type. If the .idl timestamp changed, it would recreate both as intended, however if the timestamp of the cpp was a bit later than the one of its sibbling .h, the command would be rerun.
Attachments
Patch (1.02 KB, patch)
2009-11-11 03:38 PST, Jocelyn Turcotte
hausmann: review-
Jocelyn Turcotte
Comment 1 2009-11-11 03:38:30 PST
Created attachment 42947 [details] Patch This patch make the .h use the same dependency list and generation command as the .cpp generated by the same idl.
Simon Hausmann
Comment 2 2009-11-11 13:02:01 PST
Comment on attachment 42947 [details] Patch Hmm, I see the problem. But this will break parallel builds, where make will execute the same command in parallel to generate both files at the same time: If Foo.idl is processed by $cmd to generate Foo.cpp and Foo.h at the same time, then with this patch and a parallel build $cmd is executed twice and both processes will race for generating the two files.
Jocelyn Turcotte
Comment 3 2010-03-10 05:39:29 PST
Fixed in r53187
Note You need to log in before you can comment on or make changes to this bug.