Bug 31343

Summary: Check if Storage panel exists before calling its methods
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: jorlow, michaeln, pfeldman, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
pfeldman: review-
[PATCH] fix timothy: review+

Description Yury Semikhatsky 2009-11-11 03:19:37 PST
Storage panel is diabled by defaut in Chromium and it may lead to exceptions in the frontend if localStorage is accessed in the inspected page and the frontend gets notified about the storage.
Comment 1 Yury Semikhatsky 2009-11-11 04:14:54 PST
Created attachment 42950 [details]
patch
Comment 2 Pavel Feldman 2009-11-11 11:08:14 PST
Comment on attachment 42950 [details]
patch

There is a handful of panel.storage usages overall. Why are you fixing only one?
Comment 3 Pavel Feldman 2009-11-11 11:25:16 PST
Created attachment 42983 [details]
[PATCH] fix

Otherwise things crash when Storage is one of the hidden panels on the sites that use stores....
Comment 4 Pavel Feldman 2009-11-11 13:37:53 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/inspector.js
Committed r50840
Comment 5 Yury Semikhatsky 2009-11-12 00:03:44 PST
updateDOMStorage should never be called if the panel is hidden because IC will send updates only after DOM storage entries have been requested.

(In reply to comment #2)
> (From update of attachment 42950 [details])
> There is a handful of panel.storage usages overall. Why are you fixing only
> one?