Bug 313407

Summary: style checker fails with PNG files
Product: WebKit Reporter: Karl Dubost <karlcow>
Component: Tools / TestsAssignee: Karl Dubost <karlcow>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Karl Dubost
Reported 2026-04-27 02:43:27 PDT
When having PNG files in a PR, there is error message from the style checker. ``` Traceback (most recent call last): File "/Users/karlcow/code/OpenSource/Tools/Scripts/check-webkit-style", line 46, in <module> sys.exit(CheckWebKitStyle().main()) File "/Users/karlcow/code/OpenSource/Tools/Scripts/webkitpy/style/main.py", line 132, in main patch_checker.check(patch) File "/Users/karlcow/code/OpenSource/Tools/Scripts/webkitpy/style/patchreader.py", line 79, in check self._text_file_reader.process_file(file_path=path, line_numbers=None) File "/Users/karlcow/code/OpenSource/Tools/Scripts/webkitpy/style/filereader.py", line 137, in process_file self._processor.process(lines, file_path, **kwargs) File "/Users/karlcow/code/OpenSource/Tools/Scripts/webkitpy/style/checker.py", line 1263, in process checker.check(lines, line_numbers=line_numbers) TypeError: check() got an unexpected keyword argument 'line_numbers' style-checker failed! ``` looks like a modification by Geoff Garen but not recent, on April 20. https://commits.webkit.org/311595@main
Attachments
Radar WebKit Bug Importer
Comment 1 2026-04-27 02:43:46 PDT
Karl Dubost
Comment 2 2026-04-27 02:50:46 PDT
EWS
Comment 3 2026-04-27 06:37:32 PDT
Committed 312091@main (b5484e5e0f6a): <https://commits.webkit.org/312091@main> Reviewed commits have been landed. Closing PR #63678 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.