| Summary: | Add test for Web Socket send | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yuzo Fujishima <yuzo> | ||||||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, eric, ukai, webkit.review.bot, yuzo | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | PC | ||||||||||||||
| OS: | OS X 10.5 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Yuzo Fujishima
2009-11-11 01:07:02 PST
Created attachment 42938 [details]
add test for web socket send
Hi, reviewers, Can you review this patch and submit it, if it looks good? Yuzo Comment on attachment 42938 [details]
add test for web socket send
The test itself looks good. Is websocket already added to the skipped list for platforms which don't have it turned on?
Single line ifs don't need { }
+if (window.layoutTestController) {
+ layoutTestController.waitUntilDone();
+}
+ if (window.layoutTestController) {
+ layoutTestController.notifyDone();
+ }
Created attachment 43022 [details]
add test for web socket send
Thank you for the review. Fixed the single line if's. Skipped files have been updated by https://bugs.webkit.org/show_bug.cgi?id=27492 Can you submit this if it still looks good? Yuzo Created attachment 43122 [details]
add test for web socket send
Fixed the patch such that the timeout timer is canceled on successful completion. Comment on attachment 43122 [details]
add test for web socket send
LGTM.
Comment on attachment 43122 [details]
add test for web socket send
Rejecting patch 43122 from commit-queue.
Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11704 test cases.
websocket/tests/send.html -> failed
Exiting early after 1 failures. 11698 tests run.
371.57s total testing time
11697 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
6 test cases (<1%) had stderr output
Created attachment 44284 [details]
add test for web socket send
style-queue ran check-webkit-style on attachment 44284 [details] without any errors.
Created attachment 44285 [details]
add test for web socket send
Sorry for the test breakage. A blank line was missing from the end of the expected output file. I've tested the latest patch with HEAD. Can you try again? Yuzo style-queue ran check-webkit-style on attachment 44285 [details] without any errors.
Comment on attachment 44285 [details]
add test for web socket send
This seems to be covered by simple-stress now, but it's nice to have a lighter test for non-stress cases.
+var timeoutID = setTimeout(timeOutCallback, 3000);
I wish we could find a way to simplify this incantation needed in every WebSocket test.
Comment on attachment 44285 [details] add test for web socket send Clearing flags on attachment: 44285 Committed r51721: <http://trac.webkit.org/changeset/51721> All reviewed patches have been landed. Closing bug. |