Bug 313365
| Summary: | [TestWebKitAPI] Remove Embed Frameworks phase from TestWGSL target | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 294278 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
The TestWGSL target in `TestWebKitAPI.xcodeproj` has an "Embed Frameworks" build phase that copies `JavaScriptCore.framework` from `BUILT_PRODUCTS_DIR` alongside the TestWGSL binary. This phase was added in Bug 294278 for local development convenience.
In Luxon Production builds, `JavaScriptCore.framework` is not present in `BUILT_PRODUCTS_DIR` -- it is provided through the SDK overlay. The copy phase fails because the source framework does not exist at the expected path.
Remove the "Embed Frameworks" build phase from the TestWGSL target. TestWGSL links against `JavaScriptCore.framework` via the Frameworks build phase, which resolves correctly through the SDK in both local and Luxon builds. The embed phase is unnecessary because TestWGSL is a command-line test tool, not an application bundle that needs embedded frameworks.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/175635676>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/63644
EWS
Committed 312060@main (007d79cba6e1): <https://commits.webkit.org/312060@main>
Reviewed commits have been landed. Closing PR #63644 and removing active labels.