Bug 313314

Summary: Add debug assert to verify hasDefiniteHeightByStyle agrees with the slow path
Product: WebKit Reporter: alan <zalan>
Component: New BugsAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: sgill26, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch none

alan
Reported 2026-04-25 12:08:00 PDT
ssia
Attachments
Patch (3.33 KB, patch)
2026-04-25 12:10 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (3.38 KB, patch)
2026-04-27 10:14 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (3.45 KB, patch)
2026-04-29 07:08 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2026-04-25 12:10:36 PDT
Created attachment 479300 [details] Patch
alan
Comment 2 2026-04-27 10:14:15 PDT
Created attachment 479337 [details] Patch
Sammy Gill
Comment 3 2026-04-28 09:54:22 PDT
Comment on attachment 479337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=479337&action=review > Source/WebCore/rendering/RenderBoxModelObject.cpp:377 > +static void verifyDefiniteHeightConsistency(const RenderBlock& containingBlock, bool containingBlockHasDefiniteHeightCandidate) I think it would be nice if this relayed that we were checking against the hasDefiniteHeightByStyle for consistency. Maybe this could be as simple as a comment or maybe the bool could be an enum class that had it in the name somewhere. Also, I feel like "candidate," has the implication that we may not use whatever the candidate is in some scenarios so maybe we could incorporate the relation between the ByStyle function here?
alan
Comment 4 2026-04-29 07:08:33 PDT
Created attachment 479370 [details] [fast-cq]Patch
EWS
Comment 5 2026-04-29 08:42:59 PDT
Committed 312293@main (d0444c239ed0): <https://commits.webkit.org/312293@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 479370 [details].
Radar WebKit Bug Importer
Comment 6 2026-04-29 08:43:12 PDT
<rdar://problem/175857219>
Note You need to log in before you can comment on or make changes to this bug.