Summary: | Upstreaming Chromium API gyp file | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yaar Schnitman <yaar> | ||||||
Component: | WebKit API | Assignee: | Yaar Schnitman <yaar> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, eric, japhet | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Yaar Schnitman
2009-11-10 14:38:55 PST
Created attachment 42899 [details]
modified WebKit.gyp
Comment on attachment 42899 [details]
modified WebKit.gyp
README is out of date, per our discussions in person.
.gyp should probably be 4-space indent since WebKit follows python.org python style.
Otherwise it's fine. Created attachment 42902 [details]
modified WebKit.gyp
Comment on attachment 42902 [details]
modified WebKit.gyp
awesome.
Comment on attachment 42902 [details]
modified WebKit.gyp
Rejecting patch 42902 from commit-queue.
Failed to run "['/Projects/WebKit/WebKitTools/Scripts/svn-apply', '--reviewer', 'Dimitri Glazkov']" exit_code: 1
patching file WebKit/chromium/ChangeLog
patching file WebKit/chromium/README
patching file WebKit/chromium/WebKit.gyp
patching file WebKit/chromium/webkit.gyp
Hunk #1 FAILED at 1.
File WebKit/chromium/webkit.gyp is not empty after patch, as expected
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/webkit.gyp.rej
patch -p0 --force "WebKit/chromium/webkit.gyp" returned 1. Pass --force to ignore patch failures.
It's possible svn-apply is in error here. We might have to do this in two separate commits since this is just changing the case of the file. Committed r50780: <http://trac.webkit.org/changeset/50780> |