Bug 31320

Summary: Upstreaming Chromium API gyp file
Product: WebKit Reporter: Yaar Schnitman <yaar>
Component: WebKit APIAssignee: Yaar Schnitman <yaar>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
modified WebKit.gyp
none
modified WebKit.gyp dglazkov: review+, eric: commit-queue-

Yaar Schnitman
Reported 2009-11-10 14:38:55 PST
WebKit.gyp needs to move from chromium.org's webkit/api to WebKit/chromium
Attachments
modified WebKit.gyp (18.33 KB, patch)
2009-11-10 14:50 PST, Yaar Schnitman 		no flags
DetailsFormatted DiffDiff
modified WebKit.gyp (20.94 KB, patch)
2009-11-10 15:09 PST, Yaar Schnitman 		dglazkov: review+
eric: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yaar Schnitman
Comment 1 2009-11-10 14:50:54 PST
Created attachment 42899 [details] modified WebKit.gyp
Eric Seidel (no email)
Comment 2 2009-11-10 15:02:26 PST
Comment on attachment 42899 [details] modified WebKit.gyp README is out of date, per our discussions in person. .gyp should probably be 4-space indent since WebKit follows python.org python style.
Eric Seidel (no email)
Comment 3 2009-11-10 15:02:41 PST
Otherwise it's fine.
Yaar Schnitman
Comment 4 2009-11-10 15:09:09 PST
Created attachment 42902 [details] modified WebKit.gyp
Dimitri Glazkov (Google)
Comment 5 2009-11-10 15:22:08 PST
Comment on attachment 42902 [details] modified WebKit.gyp awesome.
Eric Seidel (no email)
Comment 6 2009-11-10 16:47:51 PST
Comment on attachment 42902 [details] modified WebKit.gyp Rejecting patch 42902 from commit-queue. Failed to run "['/Projects/WebKit/WebKitTools/Scripts/svn-apply', '--reviewer', 'Dimitri Glazkov']" exit_code: 1 patching file WebKit/chromium/ChangeLog patching file WebKit/chromium/README patching file WebKit/chromium/WebKit.gyp patching file WebKit/chromium/webkit.gyp Hunk #1 FAILED at 1. File WebKit/chromium/webkit.gyp is not empty after patch, as expected 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/webkit.gyp.rej patch -p0 --force "WebKit/chromium/webkit.gyp" returned 1. Pass --force to ignore patch failures.
Eric Seidel (no email)
Comment 7 2009-11-10 16:51:05 PST
It's possible svn-apply is in error here.
Eric Seidel (no email)
Comment 8 2009-11-10 16:53:11 PST
We might have to do this in two separate commits since this is just changing the case of the file.
Eric Seidel (no email)
Comment 9 2009-11-10 16:56:38 PST
Committed r50780: <http://trac.webkit.org/changeset/50780>
Note You need to log in before you can comment on or make changes to this bug.