Bug 31320

Summary: Upstreaming Chromium API gyp file
Product: WebKit Reporter: Yaar Schnitman <yaar>
Component: WebKit APIAssignee: Yaar Schnitman <yaar>
Severity: Normal CC: dglazkov, eric, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
modified WebKit.gyp
modified WebKit.gyp dglazkov: review+, eric: commit-queue-

Description Yaar Schnitman 2009-11-10 14:38:55 PST
WebKit.gyp needs to move from chromium.org's webkit/api to WebKit/chromium
Comment 1 Yaar Schnitman 2009-11-10 14:50:54 PST
Created attachment 42899 [details]
modified WebKit.gyp
Comment 2 Eric Seidel (no email) 2009-11-10 15:02:26 PST
Comment on attachment 42899 [details]
modified WebKit.gyp

README is out of date, per our discussions in person.
.gyp should probably be 4-space indent since WebKit follows python.org python style.
Comment 3 Eric Seidel (no email) 2009-11-10 15:02:41 PST
Otherwise it's fine.
Comment 4 Yaar Schnitman 2009-11-10 15:09:09 PST
Created attachment 42902 [details]
modified WebKit.gyp
Comment 5 Dimitri Glazkov (Google) 2009-11-10 15:22:08 PST
Comment on attachment 42902 [details]
modified WebKit.gyp

Comment 6 Eric Seidel (no email) 2009-11-10 16:47:51 PST
Comment on attachment 42902 [details]
modified WebKit.gyp

Rejecting patch 42902 from commit-queue.

Failed to run "['/Projects/WebKit/WebKitTools/Scripts/svn-apply', '--reviewer', 'Dimitri Glazkov']" exit_code: 1
patching file WebKit/chromium/ChangeLog
patching file WebKit/chromium/README
patching file WebKit/chromium/WebKit.gyp
patching file WebKit/chromium/webkit.gyp
Hunk #1 FAILED at 1.
File WebKit/chromium/webkit.gyp is not empty after patch, as expected
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/webkit.gyp.rej
patch -p0 --force "WebKit/chromium/webkit.gyp" returned 1.  Pass --force to ignore patch failures.
Comment 7 Eric Seidel (no email) 2009-11-10 16:51:05 PST
It's possible svn-apply is in error here.
Comment 8 Eric Seidel (no email) 2009-11-10 16:53:11 PST
We might have to do this in two separate commits since this is just changing the case of the file.
Comment 9 Eric Seidel (no email) 2009-11-10 16:56:38 PST
Committed r50780: <http://trac.webkit.org/changeset/50780>