Bug 313121
| Summary: | Align fullscreen keyboard lock implementation with the spec | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Pieters (:zcorpan) <zcorpan> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Pieters (:zcorpan)
See https://github.com/whatwg/fullscreen/pull/232
I think at least the following are cases where WebKit is different from the current spec PR:
- WebKit stores the keyboard lock flag on Document instead of Element. This means it's not possible to track state correctly when entering and exiting fullscreen for multiple elements within the same document. Demo: https://software.hixie.ch/utilities/js/live-dom-viewer/saved/14667
- Similarly, calling requestFullscreen for the same element with different keyboard lock should update the keyboard lock flag.
- The "system" enum was removed (it is currently equivalent to "none" in WebKit as far as I can tell).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Pieters (:zcorpan)
Another difference between WebKit and Gecko is that WebKit requires calling `preventDefault()` for the Esc key to make it not exit fullscreen when pressing (instead of holding).
Radar WebKit Bug Importer
<rdar://problem/175929279>