Bug 31307

Summary: [Qt] Compile when QT_NO_WHEELEVENT is defined
Product: WebKit Reporter: Ismail Donmez <ismail>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch to fix compilation when QT_NO_WHEELEVENT is defined
eric: review-
New patch with proper changelog none

Ismail Donmez
Reported 2009-11-10 12:15:54 PST
Patch attached.
Attachments
Patch to fix compilation when QT_NO_WHEELEVENT is defined (802 bytes, patch)
2009-11-10 12:16 PST, Ismail Donmez 		eric: review-
DetailsFormatted DiffDiff
New patch with proper changelog (1.16 KB, patch)
2009-11-26 13:12 PST, Ismail Donmez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ismail Donmez
Comment 1 2009-11-10 12:16:39 PST
Created attachment 42886 [details] Patch to fix compilation when QT_NO_WHEELEVENT is defined
Eric Seidel (no email)
Comment 2 2009-11-13 13:49:29 PST
Comment on attachment 42886 [details] Patch to fix compilation when QT_NO_WHEELEVENT is defined Every change requires a ChangeLog entry. See http://webkit.org/coding/contributing.html. The diff is also rooted incorrectly. Otherwise this looks OK. Do these need to be initialized to some other value in the !NO_WHEELEVENT case?
Ismail Donmez
Comment 3 2009-11-26 13:12:42 PST
Created attachment 43931 [details] New patch with proper changelog
Ismail Donmez
Comment 4 2009-11-26 13:13:44 PST
(In reply to comment #2) > (From update of attachment 42886 [details]) > Every change requires a ChangeLog entry. See > http://webkit.org/coding/contributing.html. > > The diff is also rooted incorrectly. > > Otherwise this looks OK. Do these need to be initialized to some other value > in the !NO_WHEELEVENT case? The variables are already initialized but they are not used in the no wheel case.
Eric Seidel (no email)
Comment 5 2009-11-26 21:22:17 PST
Comment on attachment 43931 [details] New patch with proper changelog OK.
WebKit Commit Bot
Comment 6 2009-11-26 21:34:05 PST
Comment on attachment 43931 [details] New patch with proper changelog Clearing flags on attachment: 43931 Committed r51425: <http://trac.webkit.org/changeset/51425>
WebKit Commit Bot
Comment 7 2009-11-26 21:34:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.