Bug 312890
| Summary: | [CMake] Default the build to Release instead of RelWithDebInfo when CMAKE_BUILD_TYPE is not specified. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | CMake | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | NEW | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=177665 | ||
Carlos Alberto Lopez Perez
At 194203@main some code was added to warn the user when the CMAKE_BUILD_TYPE is not specified and to default the build in that case to RelWithDebInfo
But I think it would be better to default instead to Release because Release uses -O3 but RelWithDebInfo uses -O2
Note: this does not affect builds done via build-webkit script as build-webkit correctly passes the right -DCMAKE_BUILD_TYPE value
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/63228