Bug 312833
| Summary: | [cmake] build-webkit --cmake should disable experimental features on macOS | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brandon <brandonstewart> |
| Component: | Tools / Tests | Assignee: | Brandon <brandonstewart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brandon
The Xcode build does not enable ENABLE_EXPERIMENTAL_FEATURES, but the CMake
build on macOS was passing -DENABLE_EXPERIMENTAL_FEATURES=ON by default. This
divergence causes CMake builds to include incomplete or unstable feature code
that the Xcode build intentionally excludes.
Disable experimental features by default when using --cmake on Apple Cocoa
platforms, matching the Xcode build behavior.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/175203793>
Brandon
Pull request: https://github.com/WebKit/WebKit/pull/63174
EWS
Committed 311675@main (0516da02dbc3): <https://commits.webkit.org/311675@main>
Reviewed commits have been landed. Closing PR #63174 and removing active labels.