Bug 312609
| Summary: | [CMake] Skip -dead_strip in Debug builds on macOS | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | CMake | Assignee: | zak ridouh <zakr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
Source/cmake/OptionsMac.cmake unconditionally passed -Wl,-dead_strip
to the linker, while the Xcode build sets DEAD_CODE_STRIPPING = NO
for Debug (DEAD_CODE_STRIPPING[config=Debug] = NO in the various
Base.xcconfig files). This made CMake Debug builds slower to link
and stripped symbols that are useful while debugging.
Gate the option behind a generator expression so it only applies to
non-Debug configurations, matching Xcode. -dead_strip_dylibs is left
unchanged.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/175041322>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/63009
EWS
Committed 311794@main (e53d07efdb3a): <https://commits.webkit.org/311794@main>
Reviewed commits have been landed. Closing PR #63009 and removing active labels.