Bug 31250

Summary:

Make XP_UNIX tests consistent

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

Plug-ins

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
proposed patch	none

Laszlo Gombos

Reported 2009-11-08 20:18:06 PST

QtWebKit on Mac reports the following warning: WebCore/plugins/PluginView.cpp:130:7: warning: "XP_UNIX" is not defined This is because the test is testing the value of the XP_UNIX macro instead of testing weather it is defined or not. I think we should make the XP_UNIX test consistent. Patch will follow.

Attachments
proposed patch (2.54 KB, patch) 2009-11-08 20:25 PST, Laszlo Gombos	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2009-11-08 20:25:21 PST

Created attachment 42729 [details] proposed patch

Jan Alonzo

Comment 2 2009-11-09 01:20:25 PST

Comment on attachment 42729 [details] proposed patch r=me.

WebKit Commit Bot

Comment 3 2009-11-09 11:26:28 PST

Comment on attachment 42729 [details] proposed patch Clearing flags on attachment: 42729 Committed r50670: <http://trac.webkit.org/changeset/50670>

WebKit Commit Bot

Comment 4 2009-11-09 11:26:32 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.