Bug 31250

Summary: Make XP_UNIX tests consistent
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Description Laszlo Gombos 2009-11-08 20:18:06 PST
QtWebKit on Mac reports the following warning:

WebCore/plugins/PluginView.cpp:130:7: warning: "XP_UNIX" is not defined

This is because the test is testing the value of the XP_UNIX macro instead of testing weather it is defined or not. I think we should make the XP_UNIX test consistent. Patch will follow.
Comment 1 Laszlo Gombos 2009-11-08 20:25:21 PST
Created attachment 42729 [details]
proposed patch
Comment 2 Jan Alonzo 2009-11-09 01:20:25 PST
Comment on attachment 42729 [details]
proposed patch

r=me.
Comment 3 WebKit Commit Bot 2009-11-09 11:26:28 PST
Comment on attachment 42729 [details]
proposed patch

Clearing flags on attachment: 42729

Committed r50670: <http://trac.webkit.org/changeset/50670>
Comment 4 WebKit Commit Bot 2009-11-09 11:26:32 PST
All reviewed patches have been landed.  Closing bug.