Bug 312389
| Summary: | [CMake] Add YouTubeCaptionQuirk.js to WebCore_USER_AGENT_SCRIPTS for macOS | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brandon <brandonstewart> |
| Component: | Tools / Tests | Assignee: | Brandon <brandonstewart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brandon
YouTubeCaptionQuirk.js was added to USER_AGENT_SCRIPTS in
DerivedSources.make (Xcode build) but the CMake equivalent in
PlatformMac.cmake was not updated. This caused the generated
UserAgentScripts.h to lack the YouTubeCaptionQuirkJavaScript
declaration, resulting in a build failure in RenderThemeCocoa.mm.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/174848364>
Brandon
Pull request: https://github.com/WebKit/WebKit/pull/62827
EWS
Committed 311324@main (8cc33de017ef): <https://commits.webkit.org/311324@main>
Reviewed commits have been landed. Closing PR #62827 and removing active labels.