Bug 312351
| Summary: | Fix crash in FontSelectionAlgorithm when all font faces are penalized | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | New Bugs | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
styleDistance's axis-mismatch penalty paths returned the requested slope value,
but filterCapability eliminates faces whose slope range doesn't include that
value. When all faces are penalized (e.g. only italic faces available for an
oblique request), every face gets eliminated, and the next pass crashes on an
empty set.
Fix by returning slope.minimum instead, which is always within the face's own
range, so at least one face survives filtering.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
zak ridouh
<rdar://174644983>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/62800
EWS
Committed 311341@main (47b07ba22fd8): <https://commits.webkit.org/311341@main>
Reviewed commits have been landed. Closing PR #62800 and removing active labels.
Brent Fulgham
PR created for the test change: https://github.com/web-platform-tests/wpt/pull/59291