Bug 31231

Summary: Closing brace in value breaks CSS parser
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, bdakin, commit-queue, webkit.review.bot, yuzo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
test 1
none
test 2
none
Skip invalid blocks in CSS property declarations. none

Alexey Proskuryakov
Reported 2009-11-07 15:17:13 PST
Created attachment 42705 [details] test 1 From <http://habrahabr.ru/blogs/css/74565>. After e.g. '.myclass {height:{}}', nothing else gets parsed. See attached test cases.
Attachments
test 1 (201 bytes, text/html)
2009-11-07 15:17 PST, Alexey Proskuryakov 		no flags
Details
test 2 (110 bytes, text/html)
2009-11-07 15:17 PST, Alexey Proskuryakov 		no flags
Details
Skip invalid blocks in CSS property declarations. (3.86 KB, patch)
2010-01-07 23:59 PST, Yuzo Fujishima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2009-11-07 15:17:33 PST
Created attachment 42706 [details] test 2
Yuzo Fujishima
Comment 2 2010-01-07 23:59:09 PST
Created attachment 46117 [details] Skip invalid blocks in CSS property declarations.
WebKit Review Bot
Comment 3 2010-01-07 23:59:51 PST
style-queue ran check-webkit-style on attachment 46117 [details] without any errors.
Yuzo Fujishima
Comment 4 2010-01-08 00:00:43 PST
The above patch should also fix 26619. Yuzo
WebKit Commit Bot
Comment 5 2010-01-08 13:31:40 PST
Comment on attachment 46117 [details] Skip invalid blocks in CSS property declarations. Clearing flags on attachment: 46117 Committed r53004: <http://trac.webkit.org/changeset/53004>
WebKit Commit Bot
Comment 6 2010-01-08 13:31:45 PST
All reviewed patches have been landed. Closing bug.
Yuzo Fujishima
Comment 7 2010-01-11 20:11:28 PST
*** Bug 26619 has been marked as a duplicate of this bug. ***
Adele Peterson
Comment 8 2010-01-13 22:05:07 PST
This change introduced a serious bug at redfin.com - https://bugs.webkit.org/show_bug.cgi?id=33650
Note You need to log in before you can comment on or make changes to this bug.