Bug 312206
| Summary: | [Site Isolation] fast/dom/window-load-crash.html is missing "Blocked access to external URL..." console message | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anthony Tarbinian <a.tarbinian> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Anthony Tarbinian
With site isolation enabled, fast/dom/window-load-crash.html is missing "Blocked access to external URL..." console message when it tries to navigate a frame to an external URL which is normally blocked by WebKitTestRunner.
Pre site-isolation, this code lives in InjectedBundlePage::willSendRequestForFrame. However since in site isolation, the jsContext of a RemoteFrame is null and we return early before this message gets logged.
https://github.com/WebKit/WebKit/blob/98c50963bfa21c9427d6e06abfcbe9672a707541/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp#L941
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/174695731>
Anthony Tarbinian
Pull request: https://github.com/WebKit/WebKit/pull/62679
EWS
Committed 311844@main (233543e905fb): <https://commits.webkit.org/311844@main>
Reviewed commits have been landed. Closing PR #62679 and removing active labels.