Summary: | Clean up GraphicsContext's current concept of ColorSpace | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||
Component: | Layout and Rendering | Assignee: | Beth Dakin <bdakin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, darin, dglazkov | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Beth Dakin
2009-11-06 17:44:55 PST
Created attachment 42681 [details]
Patch
Darin is likely to be at least a little disappointed in this patch since it is more conservative than some other options we discussed for this cleanup. Specifically, Darin noticed that once we have a Pattern or Gradient on the GraphicsContext, we keep a pointer to it forever. I wrote code that would get rid of old Patterns and Gradients once something that is not a Pattern or Gradient is set, but a bunch of canvas pattern tests failed. I haven't investigated the failures closely enough to know whether or not clearing out the pattern is an option or not. Ultimately, it seems like that is just a bigger problem than we are trying to solve today, and I will file a follow-up bug so we can take a look at it later.
Comment on attachment 42681 [details]
Patch
Seems like a fine initial step for cleanup. r=me
(In reply to comment #1) > Darin is likely to be at least a little disappointed in this patch since it is > more conservative than some other options we discussed for this cleanup. I'm pretty happy with it. > I wrote code that would get > rid of old Patterns and Gradients once something that is not a Pattern or > Gradient is set, but a bunch of canvas pattern tests failed. I'll play with that myself if I have some free time. It doesn't seem important to tackle it any time soon -- you can get on to the color space work! No Skia changes? :-\ |