Bug 312160
| Summary: | [GTK] [2.52.2] Fails to build on s390x: 'GraphicsContextSkia.h' file not found | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alberto Garcia <berto> |
| Component: | WebKitGTK | Assignee: | Alberto Garcia <berto> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alberto Garcia
FAILED: [code=1] Source/WebCore/CMakeFiles/WebCore.dir/page/scrolling/coordinated/ScrollerCoordinated.cpp.o
/build/reproducible-path/webkit2gtk-2.52.2/Source/WebCore/page/scrolling/coordinated/ScrollerCoordinated.cpp:38:10: fatal error: 'GraphicsContextSkia.h' file not found
38 | #include "GraphicsContextSkia.h"
| ^~~~~~~~~~~~~~~~~~~~~~~
This seems to be due to https://commits.webkit.org/310298@main now using Skia for the scrollbar.
The fix is probably this one:
-#if USE(COORDINATED_GRAPHICS) && USE(THEME_ADWAITA)
+#if USE(COORDINATED_GRAPHICS) && USE(THEME_ADWAITA) && USE(SKIA)
#define USE_COORDINATED_GRAPHICS_ASYNC_SCROLLBAR 1
#endif
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alberto Garcia
Pull request: https://github.com/WebKit/WebKit/pull/62639
EWS
Committed 311126@main (85785f062b55): <https://commits.webkit.org/311126@main>
Reviewed commits have been landed. Closing PR #62639 and removing active labels.