Bug 31215
| Summary: | check-webkit-style should not warn about NULL in comments | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | hamaji, levin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
check-webkit-style should not warn about NULL in comments
example:
// Opens a database file; dirHandle should be NULL if the caller does not need
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Levin
Actually it is by design that it complains about NULL in comments.
It was following the lead of some other WK reviews, that since NULL isn't in the code, it seems odd to have it in comments.
Shouldn't it say 0 in the comment below? (I mean NULL wouldn't appear in the code.)