| Summary: | Can cache prototype lookups on uncacheable dictionaries. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | barraclough, ggaren, oliver | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
Created attachment 42816 [details]
Patch
Comment on attachment 42816 [details]
Patch
I don't like the name sortedProperties, partly because in the first loop, it isn't yet sorted, partly because it was not immediately clear to me these were pointers into the original map (modified by the entry-> writes).
I'm not sure what a good name would be, so I think a couple more comments (like, "These writes are modifying the persistent property map for the structure!". Or something.)
And the variable name 'p' is kinda sucky, too.
But the code all looks sensible, r+.
Created attachment 42842 [details]
Fix wrong expectation
Comment on attachment 42842 [details]
Fix wrong expectation
r=me
whoops :-(
Comment on attachment 42842 [details]
Fix wrong expectation
I guess the commit bot won't land build fixes. weee!
|
var o = {a:5,b:6}; var a={__proto__:o}; delete o.b; function f(o) {return o.a; }; f(a); f(a);f(a); delete o.a; o.c="FAIL"; alert(f(a));