Bug 311897
| Summary: | Support WPT ref tests with variants | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | gsnedders, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
WPT ref tests using variants don't work. Examples:
imported/w3c/web-platform-tests/css/css-backgrounds/box-shadow-radius-generated.html*
imported/w3c/web-platform-tests/css/css-view-transitions/web-animations-api-parse-pseudo-argument.html?first-pseudo=::view-transition-group*
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/174462134>
Simon Fraser (smfr)
Maybe fix:
Tools/Scripts/webkitpy/port/base.py
562 if self.test_isfile(test_name) or self.test_isdir(test_name):
563 return True
564 if '?' in test_name or '#' in test_name:
565 - fs = self._filesystem
566 - ext_parts = fs.splitext(test_name)
567 - test_name = ext_parts[0]
568 - if len(ext_parts) > 1 and '?' in ext_parts[1]:
569 - test_name += ext_parts[1].split('?')[0]
570 - if len(ext_parts) > 1 and '#' in ext_parts[1]:
571 - test_name += ext_parts[1].split('#')[0]
565 + test_name = test_name.split('?')[0].split('#')[0]
566 return self.test_isfile(test_name)
567 return False
568
Simon Fraser (smfr)
That change is fixing TestExpectations to work with params containing slashes, which also doesn't work.
Simon Fraser (smfr)
*** This bug has been marked as a duplicate of bug 278243 ***