Bug 311819 – [GLIB][JSC] stress/iterator-prototype-includes.js tests are failing since added in 310769@main

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Lauro Moura]

https://results.webkit.org/?suite=javascriptcore-tests&test=stress%2Fiterator-prototype-includes.js.default

List of failures:
        stress/iterator-prototype-includes.js.bytecode-cache
        stress/iterator-prototype-includes.js.default
        stress/iterator-prototype-includes.js.dfg-eager
        stress/iterator-prototype-includes.js.dfg-eager-no-cjit-validate
        stress/iterator-prototype-includes.js.eager-jettison-no-cjit
        stress/iterator-prototype-includes.js.ftl-eager
        stress/iterator-prototype-includes.js.ftl-eager-no-cjit
        stress/iterator-prototype-includes.js.ftl-eager-no-cjit-b3o1
        stress/iterator-prototype-includes.js.ftl-no-cjit-b3o0
        stress/iterator-prototype-includes.js.ftl-no-cjit-no-inline-validate
        stress/iterator-prototype-includes.js.ftl-no-cjit-no-put-stack-validate
        stress/iterator-prototype-includes.js.ftl-no-cjit-small-pool
        stress/iterator-prototype-includes.js.ftl-no-cjit-validate-sampling-profiler
        stress/iterator-prototype-includes.js.lockdown
        stress/iterator-prototype-includes.js.mini-mode
        stress/iterator-prototype-includes.js.no-cjit-collect-continuously
        stress/iterator-prototype-includes.js.no-cjit-validate-phases
        stress/iterator-prototype-includes.js.no-ftl
        stress/iterator-prototype-includes.js.no-llint


Example output for some of them:

stress/iterator-prototype-includes.js.lockdown: Exception: Error: call on short iterator with 2nd arg (large number): Number.MAX_VALUE: calling .includes(): Expected false but got true
stress/iterator-prototype-includes.js.lockdown: [e-mail]:5:24
stress/iterator-prototype-includes.js.lockdown: global [e-mail]:457:18
stress/iterator-prototype-includes.js.lockdown: ERROR: Unexpected exit code: 3
stress/iterator-prototype-includes.js.lockdown: Repro command:  jsc --validateOptions=true --useFTLJIT=false --useFunctionDotArguments=true --validateExceptionChecks=true --useDollarVM=true --maxPerThreadStackUsage=1572864 --useJIT=false --useGenerationalGC=false --useConcurrentGC=false --useLLIntICs=false --use
ZombieMode=true --allowDoubleShape=false --alwaysHaveABadTime=true --libpasForcePGMWithRate=14 --useIteratorIncludes=1 iterator-prototype-includes.js
stress/iterator-prototype-includes.js.default: Exception: Error: call on short iterator with 2nd arg (large number): Number.MAX_VALUE: calling .includes(): Expected false but got true
stress/iterator-prototype-includes.js.default: [e-mail]:5:24
stress/iterator-prototype-includes.js.default: global [e-mail]:457:18
stress/iterator-prototype-includes.js.ftl-no-cjit-b3o0: Exception: Error: call on short iterator with 2nd arg (large number): Number.MAX_VALUE: calling .includes(): Expected false but got true
stress/iterator-prototype-includes.js.ftl-no-cjit-b3o0: [e-mail]:5:24
stress/iterator-prototype-includes.js.ftl-no-cjit-b3o0: global [e-mail]:457:18
stress/iterator-prototype-includes.js.no-llint: Exception: Error: call on short iterator with 2nd arg (large number): Number.MAX_VALUE: calling .includes(): Expected false but got true
stress/iterator-prototype-includes.js.no-llint: [e-mail]:5:24
stress/iterator-prototype-includes.js.no-llint: global [e-mail]:457:18
stress/iterator-prototype-includes.js.bytecode-cache: Exception: Error: call on short iterator with 2nd arg (large number): Number.MAX_VALUE: calling .includes(): Expected false but got true
stress/iterator-prototype-includes.js.bytecode-cache: [e-mail]:5:24
stress/iterator-prototype-includes.js.bytecode-cache: global [e-mail]:457:18
stress/iterator-prototype-includes.js.bytecode-cache: Command '../../.vm/JavaScriptCore.framework/Helpers/jsc iterator-prototype-includes.js --validateOptions=true --useFTLJIT=false --useFunctionDotArguments=true --validateExceptionChecks=true --useDollarVM=true --maxPerThreadStackUsage=1572864 --validateOptions
=true --useFTLJIT=true --useIteratorIncludes=1' failed

[Justin Michaud]

This is gcc-only

[Justin Michaud]

toSkip = static_cast<uint64_t>(skippedAsDouble); appears to be UB

[Justin Michaud]

Pull request: https://github.com/WebKit/WebKit/pull/62511

[EWS]

Committed 311446@main (30298eb4df3c): <https://commits.webkit.org/311446@main>

Reviewed commits have been landed. Closing PR #62511 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/175005735>

[Tetsuharu Ohzeki [UTC+9]]

*** Bug 312464 has been marked as a duplicate of this bug. ***