Bug 311746
| Summary: | requestClose() on a disconnected dialog removes open attribute | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Luke Warlow <lwarlow> |
| Component: | DOM | Assignee: | Luke Warlow <lwarlow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://github.com/web-platform-tests/wpt/pull/59877 | ||
Luke Warlow
Per the spec requestClose() should early return if the dialog it's called on is disconnected, or it's document is inactive.
`data:text/html,<script>const dialog = document.createElement('dialog'); dialog.setAttribute('open', ''); dialog.requestClose(); alert(dialog.open);</script>` This should alert with true like in Chromium and Firefox.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/174855725>
Luke Warlow
Pull request: https://github.com/WebKit/WebKit/pull/64919
EWS
Committed 313251@main (c7342e9519e4): <https://commits.webkit.org/313251@main>
Reviewed commits have been landed. Closing PR #64919 and removing active labels.