Bug 311674
| Summary: | [libpas] Rebaseline tests according to recent size-boundary changes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcus Plutowski <marcus_plutowski> |
| Component: | bmalloc | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Marcus Plutowski
rdar://174265947
Recent changes to libpas (307140@main, 294862@main) have changed PAS_MIN_OBJECTS_PER_PAGE from 6 to 10, then 11, as well as changing the page-size of medium-bitfit pages from 128k to 512k.
The first of those patches broke some libpas tests (particularly in ThingyAndUtilityHeapAllocationTests.cpp and IsoHeapPartialAndBaselineTests.cpp) which check for these page boundaries, which has masked the effect of further changes from subsequent patches.
These tests should be re-baselined so that we can get back to green.
The size-boundaries as of 310711@main are
bmalloc:
```
Small Segregated: 1472B
Medium Segregated: 11776B
Small Bitfit: 1456B
Medium Bitfit: 32768B
Marge Bitfit : 380928B
```
jit:
```
Small Segregated: 1488B
Small Bitfit: 1012B
Medium Bitfit : 64768B
```
utility:
```
Small Segregated: 1400B
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marcus Plutowski
Pull request: https://github.com/WebKit/WebKit/pull/62691
EWS
Committed 311156@main (1e97ddecd4e6): <https://commits.webkit.org/311156@main>
Reviewed commits have been landed. Closing PR #62691 and removing active labels.