Bug 31167

Summary: Remove the "this is part of the KDE project" comments from code
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://trac.webkit.org/wiki/Maintenance%20and%20architecture%20list
Attachments:
Description Flags
Patch to remove KDE comments. none

Description Chris Jerdonek 2009-11-05 09:07:18 PST
The maintenance and architecture page of the WebKit wiki says--

"Besides adding features and fixing bugs, there are some maintenance tasks we need to do for WebKit. These are things we talk about all the time on the IRC channel, but some of them take a long time. I thought I'd make a list here of some of the big ones: 
...
* remove mildly misleading "this is part of the KDE project" comments 
..."

This bug report is being filed to track a patch for this issue (for all *.h, *.cpp, *.idl, and *.pm files).

The patch has been created and will be submitted once a bug number is generated.  Thanks.
Comment 1 Chris Jerdonek 2009-11-05 09:31:43 PST
Created attachment 42572 [details]
Patch to remove KDE comments.
Comment 2 Chris Jerdonek 2009-11-05 09:33:19 PST
The attached patch is somewhat large (~150 KB).  However, there are ways to make reviewing it easier.

For example, to verify quickly that no substantive lines have been deleted, you can grep the following regular expression in the diff using a text editor:

^-[^-]

To generate the patch, I used the following grep/sed command from the command-line (along with 3 or 4 touch-ups):

grep --regexp="[^@a-z_\(]KDE[^@a-z_]" --recursive --include=*.{h,cpp,idl,pm} --files-with-matches WebKit | 
xargs sed -i '' -e '
# Look for "...KDE..." -- ruling out things like "kde@", "@kde", etc.
/[^@a-z_\(]KDE[^@a-z_]/ {
# If found, read in the next two lines.
N
N
# Then delete everything except for the last-read line.
s/.*\n//
}' 

Note that I also removed the KDE comment from the following file which does not have an h/cp/idl/pm extension--

WebCore/css/maketokenizer

Thanks a lot.
Comment 3 Eric Seidel (no email) 2009-11-05 15:28:49 PST
Comment on attachment 42572 [details]
Patch to remove KDE comments.

I'm a little sad that this will cause everyone to do a full rebuild.  But it certainly wouldn't be the first time developers had to do such.

The patch looks good to me.  Marking cq+ since you're not a committer yet.

Once this lands you can update the wiki to remove the item (that page looks like it needs a lot of update actually).
Comment 4 WebKit Commit Bot 2009-11-05 15:58:05 PST
Comment on attachment 42572 [details]
Patch to remove KDE comments.

Clearing flags on attachment: 42572

Committed r50583: <http://trac.webkit.org/changeset/50583>
Comment 5 WebKit Commit Bot 2009-11-05 15:58:09 PST
All reviewed patches have been landed.  Closing bug.