Summary: | [Qt] [DRT] Fix wrong logic in LayoutTestController processWork | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> | ||||
Component: | Tools / Tests | Assignee: | Antonio Gomes <tonikitoo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | Qt | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 30573 | ||||||
Attachments: |
|
Description
Antonio Gomes
2009-11-05 05:02:23 PST
for reference: GTK: static gboolean processWork(void* data) { // if we finish all the commands, we're ready to dump state if (WorkQueue::shared()->processWork() && !gLayoutTestController->waitToDump()) dump(); WIN: void FrameLoadDelegate::processWork() { (...) // if we finish all the commands, we're ready to dump state if (WorkQueue::shared()->processWork() && !::gLayoutTestController->waitToDump()) dump(); MAC: - (void)processWork:(id)dummy { (...) // if we finish all the commands, we're ready to dump state if (WorkQueue::shared()->processWork() && !gLayoutTestController->waitToDump()) dump(); Created attachment 42560 [details] (committed in r50622) patch patch make LayoutTestController::proccessWork to dump whole if WorkQueue returns 'true' it makes qt compliant to other drt's (mac, win, gtk) Comment on attachment 42560 [details] (committed in r50622) patch Seems plausible. |