Bug 311553
| Summary: | SVG getStartPositionOfChar/getEndPositionOfChar should not include dominant-baseline shift in returned position | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | SVG | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=311597 https://github.com/web-platform-tests/wpt/pull/59318 |
||
| Bug Depends on: | |||
| Bug Blocks: | 297455 | ||
Karl Dubost
getStartPositionOfChar() and getEndPositionOfChar() return positions that include the dominant-baseline shift baked into the SVG text fragment y-coordinate. Chrome and Firefox return positions without the baseline shift, reflecting the y attribute value rather than the visual rendering position.
The issue is in SVGTextLayoutEngine.cpp where the baseline shift from dominant-baseline is applied to the fragment y-position (line 603: y -= baselineShift) and stored in the fragment (line 635: fragment.y = y). The SVGTextQuery API reads directly from fragment.y, so it returns the shifted position.
The fix is to store the baseline shift separately in SVGTextFragment and apply it only during painting, not in the stored position. This makes the query APIs return the correct unshifted position matching Chrome/Firefox behavior.
Related: Bug 297455 (dominant-baseline inheritance fix exposes this issue more broadly)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/174145885>
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/62106
EWS
Committed 311450@main (48ca57667b1e): <https://commits.webkit.org/311450@main>
Reviewed commits have been landed. Closing PR #62106 and removing active labels.
Karl Dubost
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/59318