Bug 311531
| Summary: | [Navigation API] Break up innerDispatchNavigateEvent into logical helpers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <basuke> |
| Component: | DOM | Assignee: | Basuke Suzuki <basuke> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Basuke Suzuki
innerDispatchNavigateEvent() is 278 lines with 9 logical sections, nested lambdas, and complex control flow. Extract 3 methods: handleSameDocumentNavigation() (92 lines), setupInterceptionState() (46 lines), and createNavigateEvent() (55 lines). This is a pure structural refactoring with no behavior change, done to improve readability and make future changes (like the microtask timing fix in bug 311298) easier to review.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Basuke Suzuki
rdar://174120905
Basuke Suzuki
Pull request: https://github.com/WebKit/WebKit/pull/62082
EWS
Committed 310617@main (c0722f0a0eda): <https://commits.webkit.org/310617@main>
Reviewed commits have been landed. Closing PR #62082 and removing active labels.