Bug 311347
| Summary: | [GStreamer] Use an explicit allowlist of AAC AOTs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alicia Boya García <aboya> |
| Component: | WebKitGTK | Assignee: | Alicia Boya García <aboya> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alicia Boya García
Currently the GStreamer ports of WebKit report support to any codec
string starting with "mp4a" if there is a decoder that supports
audio/mpeg, mpegversion=4. This is too optimistic and can lead to
applications choosing to use newer MPEG-4 Audio codecs not yet
supported by the user's system.
This patch makes WebKit play it safer and instead only report support
for AOTs with widespread support.
This includes reporting AOT 42 (typically used with xHE-AAC) as not
supported. Ideally we would query support for it somehow and reply
accordingly, but that would necessitate decoders to provide a uniform
API for querying such support, which unfortunately does not exist (and
would be tricky in practice as support is not always binary). An
environment variable is provided to declare explicit support or lack
thereof in environments where this is well-known, as well as for
debugging and experimentation.
* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::initializeDecoders):
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alicia Boya García
Pull request: https://github.com/WebKit/WebKit/pull/61915
EWS
Committed 310634@main (e33ca763cfd8): <https://commits.webkit.org/310634@main>
Reviewed commits have been landed. Closing PR #61915 and removing active labels.