Bug 311267
| Summary: | [WebXR][SaferCPP] Do not hide smart pointers behind auto | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> |
| Component: | WebXR | Assignee: | Sergio Villar Senin <svillar> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | djg, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sergio Villar Senin
As stated by the SaferCPP guidelines https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines#do-not-hide-smart-pointers-behind-auto we should not do that. There are plenty of examples of this in the WebXR implementation.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sergio Villar Senin
Pull request: https://github.com/WebKit/WebKit/pull/61831
EWS
Committed 310423@main (750203030daa): <https://commits.webkit.org/310423@main>
Reviewed commits have been landed. Closing PR #61831 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/173915342>