Bug 311208
| Summary: | [WPE] Enable remaining WebKitFaviconDatabase API tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | WPE WebKit | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 296927 | ||
| Bug Blocks: | |||
Adrian Perez
As per bug #296927 we will be enabling the new favicon API for the WPE port, but making
all the API tests work would be quite a bit of churn because it would entail peppering many
preprocessor guards around, so instead it would be better to rewrite them in a way that the
tests a.) are more robust, as currently they are quite flaky, and b.) we can use helper classes
and methods that have different implementations depending on which build options and port
were enabled to avoid putting preprocessor guards everywhere.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |