Bug 311126
| Summary: | [Accessibility] Remove overly strict AX_ASSERT in WebPage::inheritAccessibilityMode | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brandon <brandonstewart> |
| Component: | Accessibility | Assignee: | Brandon <brandonstewart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | andresg_22, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 26 | ||
| Hardware: | Mac (Apple Silicon) | ||
| OS: | macOS 26 | ||
Brandon
The assertion assumed that if the UIProcess sends an Off accessibility mode during WebPage creation, accessibility must not already be enabled in the WebContent process. This doesn't hold when multiple WebPages share a process: an earlier page may have enabled accessibility process-wide via a non-Off mode, and a subsequent page receiving Off is normal.
The function already handles this correctly by returning early (no-op). The assertion was purely defensive and the crash it caused was worse than the silent no-op.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/173716198>
Brandon
Pull request: https://github.com/WebKit/WebKit/pull/61711
EWS
Committed 310276@main (038aac1ed918): <https://commits.webkit.org/310276@main>
Reviewed commits have been landed. Closing PR #61711 and removing active labels.