Bug 31102 – [Gtk] Build failure with --enable-introspection

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Priit Laes (IRC: plaes)]

I'm trying to build 1.1.16 tarball with gobject-introspection support, but this fails with weird error:
[snip]
make[1]: *** No rule to make target `WebKit/gtk/JSCore-1.0.gir', needed by `WebKit-1.0.gir'.  Stop.
[/snip]

[Priit Laes (IRC: plaes)]

Created attachment 42454 [details]
build.log

Build log...

[Jan Alonzo]

The fix to this is to add --enable-introspection in DISTCHECK_CONFIGURE_FLAGS on top of GNUmakefile.am. It would be nice if we can add the other features as well.

[Priit Laes (IRC: plaes)]

It seems that we also need to give some kind of extra paths to g-ir-scanner:

[snip]
/usr/bin/g-ir-scanner -v --namespace WebKit --nsversion=1.0 \
	     --include=GObject-2.0 \
	     --include=Gtk-2.0 \
	     --include=JSCore-1.0 \
	     --include=Soup-2.4 \
	     --library=webkit-1.0 \
	     --libtool="./doltlibtool" \
	     --pkg gobject-2.0 \
	     --pkg gtk+-2.0 \
	     --output WebKit-1.0.gir \
	     -I./WebKit/gtk \
	     -I./WebKit/gtk \
	     -I./JavaScriptCore/ForwardingHeaders \
	     -I. \
	     ./WebKit/gtk/webkit/webkit.h ./WebKit/gtk/webkit/webkitdefines.h ./WebKit/gtk/webkit/webkitdownload.h ./WebKit/gtk/webkit/webkiterror.h ./WebKit/gtk/webkit/webkithittestresult.h ./WebKit/gtk/webkit/webkitnetworkrequest.h ./WebKit/gtk/webkit/webkitnetworkresponse.h ./WebKit/gtk/webkit/webkitsoupauthdialog.h ./WebKit/gtk/webkit/webkitwebbackforwardlist.h ./WebKit/gtk/webkit/webkitwebdatasource.h ./WebKit/gtk/webkit/webkitwebframe.h ./WebKit/gtk/webkit/webkitwebhistoryitem.h ./WebKit/gtk/webkit/webkitwebinspector.h ./WebKit/gtk/webkit/webkitwebnavigationaction.h ./WebKit/gtk/webkit/webkitwebpolicydecision.h ./WebKit/gtk/webkit/webkitwebresource.h ./WebKit/gtk/webkit/webkitwebsettings.h ./WebKit/gtk/webkit/webkitwebwindowfeatures.h ./WebKit/gtk/webkit/webkitwebview.h ./WebKit/gtk/webkit/webkitwebdatabase.h ./WebKit/gtk/webkit/webkitsecurityorigin.h ./WebKit/gtk/webkit/webkitversion.h
[/snip]

Traceback (most recent call last):
  File "/usr/bin/g-ir-scanner", line 38, in <module>
    sys.exit(scanner_main(sys.argv))
  File "/usr/lib64/gobject-introspection/giscanner/scannermain.py", line 277, in scanner_main
    transformer.register_include(include_obj)
  File "/usr/lib64/gobject-introspection/giscanner/transformer.py", line 111, in register_include
    filename = self._find_include(include)
  File "/usr/lib64/gobject-introspection/giscanner/transformer.py", line 129, in _find_include
    % (girname, searchdirs))
ValueError: Couldn't find include 'JSCore-1.0.gir' (search path: ['/usr/local/share/gir-1.0', '/usr/share/gir-1.0', '/usr/share/gdm/gir-1.0', '/usr/share/gir-1.0', '/usr/share/gir-1.0', '/usr/share/gir-1.0'])
make[1]: *** [WebKit-1.0.gir] Error 1

[Priit Laes (IRC: plaes)]

Created attachment 42478 [details]
webkit-gobject-introspection-paths.patch

This adds search and include paths so gobject-introspection tools find correct JSCore-1.0 gir.

[Jan Alonzo]

Comment on attachment 42478 [details]
webkit-gobject-introspection-paths.patch

>  %.typelib: %.gir $(G_IR_COMPILER)
> -	$(AM_V_GEN)$(G_IR_COMPILER) $< -o $@
> +	$(AM_V_GEN)$(G_IR_COMPILER) \
> +	     --includedir $(top_srcdir)/WebKit/gtk \
> +	     $< -o $@

Is it possible to make this a one-liner as it was before? Otherwise, patch is ok. 

Thanks.

[Priit Laes (IRC: plaes)]

Created attachment 42515 [details]
webkit-bug-31102-fix-introspection-build.patch

[WebKit Commit Bot]

Comment on attachment 42515 [details]
webkit-bug-31102-fix-introspection-build.patch

Clearing flags on attachment: 42515

Committed r50559: <http://trac.webkit.org/changeset/50559>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.