Bug 310967
| Summary: | [PlayStation] Fix alert/confirm/prompt dialogs not working in MiniBrowser | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Pardeep Yadav <pardeep.yadav> |
| Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Pardeep Yadav
Fixed an issue where JavaScript dialog APIs (alert, confirm, prompt) do not work in MiniBrowser on the PlayStation port. Clicking buttons do not open dialogs. Root cause is that MiniBrowser of PlayStation port does not register callback for JavaScript dialog APIs (alert, confirm, prompt).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Pardeep Yadav
Summary
* Fixed an issue where JavaScript dialog APIs (alert, confirm, prompt) do not work in MiniBrowser on the PlayStation port. Clicking buttons do not open dialogs.
Root Cause
* The MiniBrowser of PlayStation port does not register callback for JavaScript dialog APIs (alert, confirm, prompt).
Fix
* Added runJavaScriptAlert and Register to MiniBrowser. Added WKPageRunJavaScriptAlertResultListenerCall to runJavaScriptAlert.
* Added runJavaScriptConfirm and Register to MiniBrowser. Added WKPageRunJavaScriptConfirmResultListenerCall to runJavaScriptConfirm.
* Added runJavaScriptPrompt and Register to MiniBrowser. Added WKPageRunJavaScriptPromptResultListenerCall to runJavaScriptPrompt
Testing
* Verified that alert(), confirm(), and prompt() open dialog box in MiniBrowser of PlayStation port.
* Tested with simple HTML pages triggering each dialog type.
* Changes only applicable for PlayStation port.
Pardeep Yadav
Pull request: https://github.com/WebKit/WebKit/pull/61564
Radar WebKit Bug Importer
<rdar://problem/174070125>
EWS
Committed 310742@main (1cda92774256): <https://commits.webkit.org/310742@main>
Reviewed commits have been landed. Closing PR #61564 and removing active labels.