Bug 31085

Summary:

JavaScriptCore.gyp should not turn on BUILDING_ON_LEOPARD

Product:

WebKit

Reporter:

Mark Mentovai <mark>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Remove BUILDING_ON_LEOPARD from JavaScriptCore.gyp	none

Mark Mentovai

Reported 2009-11-03 14:24:05 PST

JavaScriptCore/wtf/Platform.h is responsible for setting BUILDING_ON_LEOPARD or whatever the other appropriate macro is. JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp should not define it too.

Attachments
Remove BUILDING_ON_LEOPARD from JavaScriptCore.gyp (1.14 KB, patch) 2009-11-03 14:42 PST, Mark Mentovai	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Mentovai

Comment 1 2009-11-03 14:42:53 PST

Created attachment 42421 [details] Remove BUILDING_ON_LEOPARD from JavaScriptCore.gyp

Eric Seidel (no email)

Comment 2 2009-11-03 16:30:10 PST

Comment on attachment 42421 [details] Remove BUILDING_ON_LEOPARD from JavaScriptCore.gyp Makes sense to me.

Mark Mentovai

Comment 3 2009-11-03 20:58:49 PST

I fed this to the Chromium try servers and it looks good. http://codereview.chromium.org/355015 This is ready for checkin.

WebKit Commit Bot

Comment 4 2009-11-04 10:21:25 PST

Comment on attachment 42421 [details] Remove BUILDING_ON_LEOPARD from JavaScriptCore.gyp Clearing flags on attachment: 42421 Committed r50517: <http://trac.webkit.org/changeset/50517>

WebKit Commit Bot

Comment 5 2009-11-04 10:21:29 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.