Bug 310683
| Summary: | [Tahoe Debug] editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html is a flaky text failure. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego De La Toba <d_delatoba> |
| Component: | Layout and Rendering | Assignee: | Diego De La Toba <d_delatoba> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, bfulgham, jbedard, megan_gardner, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Diego De La Toba
editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html is a flaky text failure on Tahoe Debug.
HISTORY:
https://results.webkit.org/?suite=layout-tests&test=editing%2FexecCommand%2Fapply-inline-style-to-element-with-no-renderer-crash.html&style=debug
DIFF:
--- /Volumes/Data/worker/Apple-Tahoe-Debug-AppleSilicon-WK2-Tests/build/layout-test-results/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash-expected.txt
+++ /Volumes/Data/worker/Apple-Tahoe-Debug-AppleSilicon-WK2-Tests/build/layout-test-results/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash-actual.txt
@@ -1,3 +1,4 @@
+%uef5f%u9776%u63
PASS apply-inline-style-to-element-with-no-renderer-crash
DIFF URL:
https://build.webkit.org/results/Apple-Tahoe-Debug-AppleSilicon-WK2-Tests/309871@main%20(1429)/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash-pretty-diff.html
REPRODUCTION:
I was able to reproduce on macOS 26.3 debug with the following:
run-webkit-tests --no-build --no-retry --no-show-results --exit-after-n-failures=1 --expect-pass --iterations=266 --force --debug editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html
I am marking expectations as pass fail while this pends investigation.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/173282462>
Diego De La Toba
Test gardening pull request: https://github.com/WebKit/WebKit/pull/61297
EWS
Test gardening commit 309882@main (b6d3eda7fbfd): <https://commits.webkit.org/309882@main>
Reviewed commits have been landed. Closing PR #61297 and removing active labels.
Diego De La Toba
The test is flaky because the editing commands (Transpose, CreateLink, Undo) leave the DOM in a restructured state where text content from the SVG <tspan> element (%uef5f%u9776%u638a) non-deterministically appears in the text dump. Since the test's goal is only to verify that these operations don't cause a crash, it is safe to remove the SVG element from the DOM after the test completes to ensure deterministic output.
A potential test adjustment is to remove the SVG element before the test runner captures the text dump. Putting this up as a PR, please review.
Diego De La Toba
Pull request: https://github.com/WebKit/WebKit/pull/61345
EWS
Committed 310011@main (c93f90c3bb07): <https://commits.webkit.org/310011@main>
Reviewed commits have been landed. Closing PR #61345 and removing active labels.
Alexey Proskuryakov
Isn't this covering up for a WebKit bug? There is no such thing as a "mangled DOM state" supposed to result in nondeterministic rendering.
Diego De La Toba
Yes if the edits should result in a deterministic output then this is masking a genuine WebKit bug with how it applies style changes. Since the test's goal is only to verify that these operations don't cause a crash, I think this change is appropriate for now while this gets escalated for nondeterministic rendering.
Alexey Proskuryakov
Would you be willing to file a bug about that?