Bug 310676 – [Site Isolation] Inconsistent console message ordering for tests which use Document::printNavigationErrorMessage compared to before Site Isolation

• Component: New Bugs
• Status: RESOLVED FIXED

[Anthony Tarbinian]

Tests which trigger Document::printNavigationErrorMessage will print out certain console log messages differently to their -expected.txt when run with Site Isolation enabled vs disabled.

This is due to the fact that printNavigationErrorMessage calls frame.documentURLForConsoleLog. If frame is a LocalFrame, it will grab the document URL synchronously from document->url(). However, if frame is a RemoteFrame an asynchronous IPC call is sent to retrieve the URL.

This difference in timing reveals itself in some tests which include the separate JS Exception which gets thrown in their -expected.txt file. With site isolation enabled, the message from printNavigationErrorMessage gets printed out at a later time than without site isolation. This allows the JS Exception to get printed before and cause a text diff -> test failure. 

See this -expected.txt for example: https://github.com/WebKit/WebKit/blob/875e3a58a1b2889a8cf92d13a650be5c652e0d0c/LayoutTests/http/tests/security/block-top-level-navigation-to-different-scheme-by-third-party-iframes-expected.txt#L3-L4

This is what it looks like pre Site Isolation
```
CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate navigation for frame with URL 'http://127.0.0.1:8000/security/block-top-level-navigation-to-different-scheme-by-third-party-iframes.html' from frame with URL 'http://localhost:8000/security/resources/navigate-top-level-frame-to-failure-page-different-scheme.html'. The frame attempting navigation of the top-level window is cross-origin or untrusted and the user has never interacted with the frame.

CONSOLE MESSAGE: SecurityError: The operation is insecure.
CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate navigation for frame with URL 'http://127.0.0.1:8000/security/block-top-level-navigation-to-different-scheme-by-third-party-iframes.html' from frame with URL 'http://localhost:8000/security/resources/navigate-top-level-frame-to-failure-page-different-scheme.html'. The frame attempting navigation of the top-level window is cross-origin or untrusted and the user has never interacted with the frame.

CONSOLE MESSAGE: SecurityError: The operation is insecure.
```

This is what is printed with Site Isolation
```
CONSOLE MESSAGE: SecurityError: The operation is insecure.
CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate navigation for frame with URL 'http://127.0.0.1:8000/security/block-top-level-navigation-to-different-scheme-by-third-party-iframes.html' from frame with URL 'http://localhost:8000/security/resources/navigate-top-level-frame-to-failure-page-different-scheme.html'. The frame attempting navigation of the top-level window is cross-origin or untrusted and the user has never interacted with the frame.

CONSOLE MESSAGE: SecurityError: The operation is insecure.
CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate navigation for frame with URL 'http://127.0.0.1:8000/security/block-top-level-navigation-to-different-scheme-by-third-party-iframes.html' from frame with URL 'http://localhost:8000/security/resources/navigate-top-level-frame-to-failure-page-different-scheme.html'. The frame attempting navigation of the top-level window is cross-origin or untrusted and the user has never interacted with the frame.
```

[Radar WebKit Bug Importer]

<rdar://problem/173279243>

[Anthony Tarbinian]

Pull request: https://github.com/WebKit/WebKit/pull/61287

[EWS]

Committed 309948@main (33b1b5a695b2): <https://commits.webkit.org/309948@main>

Reviewed commits have been landed. Closing PR #61287 and removing active labels.