Bug 310634
| Summary: | [CMake][GStreamer] Allow toggling USE_GSTREAMER to disable all multimedia support | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | philn, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=269147 https://bugs.webkit.org/show_bug.cgi?id=269145 https://bugs.webkit.org/show_bug.cgi?id=290184 |
||
Adrian Perez
Historically disabling multimedia support has been achieved with:
cmake -DPORT=<WPE|GTK> -DENABLE_VIDEO=OFF ...
Then WebAudio was added to the mix, and we started using:
cmake -DPORT=<WPE|GTK> -DENABLE_VIDEO=OFF -DENABLE_WEB_AUDIO=OFF ...
Now we also have WebCodecs, which means this is becoming annoying:
cmake -DPORT=<WPE|GTK> -DENABLE_VIDEO=OFF -DENABLE_WEB_AUDIO=OFF -DENABLE_WEB_CODECS=OFF ...
There is in interval USE_GSTREAMER variable which could be promoted to an
option, which along with adding the needed dependencies would allow to use:
cmake -DPORT=<WPE|GTK> -DUSE_GSTREAMER=OFF ...
This would be handy because in nearly in all situations where multimedia
support gets disabled are builds targeting embedded use-cases where
the goal is to 1.) actually disable features that won't be used, and 2.) at
the same time completely avoid needing GStreamer.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Oh, and we also have ENABLE_SPEECH_SYNTHESIS which also needs USE_GSTREAMER.
Philippe Normand
The virus is spreading.
Adrian Perez
(In reply to Philippe Normand from comment #2)
> The virus is spreading.
🤣
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/61274
EWS
Committed 309883@main (92179a19a0f1): <https://commits.webkit.org/309883@main>
Reviewed commits have been landed. Closing PR #61274 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/173283246>