| Summary: | [Gtk] Build fails with gtk+-2.10 (no tested with older releases) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Cyprien Nicolas <c.nicolas> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | christian, jmalonzo, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
The requirement of 2.10 is actually correct. The call to the new function should be guarded by #ifdefs instead. Created attachment 44437 [details]
Guard GTK+ 2.12 specific tooltip code with #ifdef.
Attachment 44437 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:445: Missing space after , [whitespace/comma] [3]
Total errors found: 1
Comment on attachment 44437 [details] Guard GTK+ 2.12 specific tooltip code with #ifdef. > + [Gtk] Build fails with gtk+-2.10 (no tested with older releases) s/no/not/ ? and I have no idea what the style check script is aiming at... 2009-12-13 Christian Dywan <christian@twotoasts.de> Reviewed by Holger Freyther. http://bugs.webkit.org/show_bug.cgi?id=31014 [Gtk] Build fails with gtk+-2.10 (no tested with older releases) Guard GTK+ 2.12 specific tooltip code with #ifdef. * WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement): |
Hello guys, I tried to build WebKit-Gtk, both 1.1.15.3 and 1.1.6, downloaded today from the webkitgtk.org website, and the build fails. Here is my configure command, which exits normally: ./configure --prefix=${HOME}/local/`hostname` --enable-web-sockets (BTW, ./configure --help says: "--enable-web-sockets enable support for Web Sockets default=yes", but it seems to default to no, that should be another bug report) Here is the error: CXX WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-ChromeClientGtk.lo WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp: In member function ‘virtual void WebKit::ChromeClient::mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned int)’: WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:453: error: ‘gtk_tooltip_trigger_tooltip_query’ was not declared in this scope make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-ChromeClientGtk.lo] Error 1 make[1]: Leaving directory `/auto/sop-nas2a/u/sop-nas2a/vol/home_indes/cnicolas/NOSAVE/webkit/WebKitGTK/webkit-1.1.16' make: *** [all] Error 2 pkg-config tells me I have gtk+ 2.10 $ pkg-config --modversion gtk+-2.0 2.10.14 I checked for the GTK+ API, and `gtk_tooltip_trigger_tooltip_query' comes with the new GtkTooltip API, which is available since Gtk+-2.12, source: http://library.gnome.org/devel/gtk/unstable/GtkTooltip.html So I think the autoconf/configure should be updated to fail if the gtk+ lib is too old for webkit-gtk...