Bug 310052
| Summary: | [Tahoe arm64] inspector/unit-tests/array-utilities.html is a flaky text/timeout failure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego De La Toba <d_delatoba> |
| Component: | New Bugs | Assignee: | Diego De La Toba <d_delatoba> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Diego De La Toba
inspector/unit-tests/array-utilities.html is a flaky text failure on macOS release and flaky timeout on debug
HISTORY:
https://results.webkit.org/?suite=layout-tests&test=inspector%2Funit-tests%2Farray-utilities.html
TEXT DIFF RELEASE:
--- /Volumes/Data/worker/Apple-Tahoe-Release-AppleSilicon-WK2-Tests/build/layout-test-results/inspector/unit-tests/array-utilities-expected.txt
+++ /Volumes/Data/worker/Apple-Tahoe-Release-AppleSilicon-WK2-Tests/build/layout-test-results/inspector/unit-tests/array-utilities-actual.txt
@@ -186,5 +186,5 @@
Object (doesn't have [Symbol.iterator]):
PASS: Should produce an exception.
-TypeError: {} is not iterable
+TypeError: undefined is not a function (near '...item of iterable...')
TEXT DIFF DEBUG:
--- /Volumes/Data/Builds/Mac/Debug/TestBuild309333@main/layout-test-results/inspector/unit-tests/array-utilities-expected.txt
+++ /Volumes/Data/Builds/Mac/Debug/TestBuild309333@main/layout-test-results/inspector/unit-tests/array-utilities-actual.txt
@@ -1,3 +1,5 @@
+FAIL: Timed out waiting for notifyDone to be called
+
== Running test suite: ArrayUtilities
-- Running test case: Array.prototype.min
DIFF URL RELEASE:
https://build.webkit.org/results/Apple-Tahoe-Release-AppleSilicon-WK2-Tests/309238@main%20(2404)/inspector/unit-tests/array-utilities-pretty-diff.html
REPRODUCTION:
run-webkit-tests --no-build --no-retry --no-show-results --exit-after-n-failures=1 --expect-pass --iterations=299 --force -f --clobber-old-results --run-singly inspector/unit-tests/array-utilities.html --<STYLE>
I am going to mark expectations as pass fail timeout while this pends investigation.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/172695961>
Diego De La Toba
Test gardening pull request: https://github.com/WebKit/WebKit/pull/60722
EWS
Test gardening commit 309351@main (020b63f1962c): <https://commits.webkit.org/309351@main>
Reviewed commits have been landed. Closing PR #60722 and removing active labels.
Diego De La Toba
Inconsistent logging from expectException() is causing flaky text failures on release, looks like this is timing related since it occurs on tests ran with --run-singly.
Both:
TypeError: {} is not iterable -
TypeError: undefined is not a function (near '...item of iterable...')
Are valid outputs since they raise TypeError however, the test harness does not account for this. A potential fix is a manual try/catch that asserts e instanceof TypeError, validating the error type programmatically rather than matching the message string.
Diego De La Toba
Pull request: https://github.com/WebKit/WebKit/pull/60725
EWS
Committed 309385@main (f765be186673): <https://commits.webkit.org/309385@main>
Reviewed commits have been landed. Closing PR #60725 and removing active labels.