Bug 309877
| Summary: | Rendering: further naming tweaks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | CSS | Assignee: | Anne van Kesteren <annevk> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Anne van Kesteren
In Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp the static hasRelativeOrIntrinsicSizeForGridItem has the wrong name as it handles more than relative and intrinsic sizes. It handles relative, keyword sizing, and auto.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Anne van Kesteren
RenderBox::computeIntrinsicLogicalContentHeightUsingGeneric also has the wrong name as it attempts to handle all sizing keywords.
Anne van Kesteren
In RenderBox::computeContentAndScrollbarLogicalHeightUsing rename intrinsic to keywordSize.
Anne van Kesteren
Pull request: https://github.com/WebKit/WebKit/pull/60578
EWS
Committed 309319@main (ef9155e5b802): <https://commits.webkit.org/309319@main>
Reviewed commits have been landed. Closing PR #60578 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/172660094>