Bug 309852
| Summary: | 100% of page load nw_activities from WebKit appear to be completed with reason "cancelled" | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | New Bugs | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brent Fulgham
The `nw_activity` mechanism in libnetcore provides us an opportunity to indicate load success or failure in a way that can be reviewed with a sysdiagnose so that we can help track down load failures. Currently all WebKit loads appear to be user cancelled (though sub-resource loads do show success properly).
This patch corrects the cause of this problem (easy), and adds a new test to confirm this continues to work (much harder!)
<rdar://problem/81871432>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
<rdar://problem/81871432>
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/60529
EWS
Committed 309444@main (7513a10f4009): <https://commits.webkit.org/309444@main>
Reviewed commits have been landed. Closing PR #60529 and removing active labels.
EWS
Committed 305413.543@safari-7624-branch (86090cffe32b): <https://commits.webkit.org/305413.543@safari-7624-branch>
Reviewed commits have been landed. Closing PR #4773 and removing active labels.